Skip to content

move ParallelLinuxPerfScriptStackSource to TraceEvent, fixes #1103 - #1112

Merged
brianrob merged 3 commits into
microsoft:masterfrom
adamsitnik:lttngToTraceEvent
Mar 7, 2020
Merged

move ParallelLinuxPerfScriptStackSource to TraceEvent, fixes #1103#1112
brianrob merged 3 commits into
microsoft:masterfrom
adamsitnik:lttngToTraceEvent

Conversation

@adamsitnik

Copy link
Copy Markdown
Member

@adamsitnik

Copy link
Copy Markdown
Member Author

Please excuse me, but for some reason the build succeded on my machine while it should have failed.

It turns out that .NET Standard 1.6 is missing some very basic APIs and types like ApplicationException or Stream.Close:

@brianrob I've added a rule to the project file to not compile these types for .NET Standard 1.6. I hope that it's OK.

@brianrob

brianrob commented Mar 6, 2020

Copy link
Copy Markdown
Member

namespace Diagnostics.Tracing.StackSources

As part of the move, let's change the namespace for these classes to be Microsoft.Diagnostics.Tracing.StackSources.


Refers to: src/TraceEvent/Stacks/Linux/LinuxPerfScriptEventParser.cs:15 in e3658a4. [](commit_id = e3658a4, deletion_comment = False)

@brianrob

brianrob commented Mar 6, 2020

Copy link
Copy Markdown
Member

namespace PerfView.Utilities

Let's put this one into Microsoft.Diagnostics.Tracing.Utilities.


Refers to: src/TraceEvent/Utilities/FastStream.cs:6 in e3658a4. [](commit_id = e3658a4, deletion_comment = False)

@brianrob

brianrob commented Mar 6, 2020

Copy link
Copy Markdown
Member

@adamsitnik I think it will be fine to not compile these types for the netstandard1.6 target. I believe this is around for users of older runtimes (e.g. older desktop and .NET Core 1.x). It's actually probably safe to remove the netstandard1.6 target entirely, but we don't need to do that now.

@brianrob brianrob left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small requests, but otherwise, looks good.

@adamsitnik

Copy link
Copy Markdown
Member Author

@brianrob thanks for the review! I've changed the namespaces (which was a good idea BTW)

@brianrob brianrob left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @adamsitnik!

@brianrob
brianrob merged commit cfc2298 into microsoft:master Mar 7, 2020
@adamsitnik
adamsitnik deleted the lttngToTraceEvent branch September 26, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants