Let SegmentedList Handle more than 2^31-1 elements - #1486
Conversation
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.3. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.1...1.5.3) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
To clarify, you are referring to the number of elements in the collection or just the number of bytes it takes to represent those elements? |
|
I fixed the message, elements. |
|
What about just making |
|
That is true, although we don't use that code at all in any of the places that use this data structure, so I am fine with either solution. Although, we would also need to change the indexer, as well as count. That was the main reason I removed the interfaces. |
|
Agreed with @sharwell, I would like to keep the implementation, but let's throw if the operation can't be run because the collection is too large. |
034994c to
1242006
Compare
mpeyrotc
changed the title
…arn/src/PerfViewJS/spa/url-parse-1.5.3 Bump url-parse from 1.5.1 to 1.5.3 in /src/PerfViewJS/spa
Fix CVE Alerts for PerfViewJS
Remove references to OpenCover
More CVE Fixes for PerfViewJS
Address More Node Package CVE Issues in PerfViewJS
4baa765 to
7dd8b43
Compare
brianrob
left a comment
brianrob
left a comment
There was a problem hiding this comment.
Merging this into the feature branch to unblock progress. I will do further review there.
3 participants
Since we want to support collections that are larger than 2^31 - 1 elements, this PR changes all our indexing logic to use longs and makes sure that in interface methods from ICollection and IReadOnlyList that require us to continue using ints we throw when we pass their max limit.