Embed missing System.Text.Json transitive dependencies in PerfView#2404
Merged
Conversation
System.Text.Json 9.0.8 has transitive dependencies on System.IO.Pipelines and Microsoft.Bcl.AsyncInterfaces that were not being embedded in the self-extracting PerfView EXE. When these DLLs are absent at runtime, System.Text.Json fails to parse ProcessMappingMetadata JSON, causing all ELF and PE module binary formats to be reported as Unknown. This prevents symbol resolution for Linux .nettrace traces. Add both packages to Directory.Packages.props and embed them as resources in PerfView.csproj alongside the existing System.Text.Json dependencies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
leculver
approved these changes
Apr 4, 2026
This was referenced Apr 7, 2026
Merged
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The self-extracting PerfView EXE is missing two transitive dependencies of System.Text.Json 9.0.8:
System.IO.Pipelines.dllMicrosoft.Bcl.AsyncInterfaces.dllWithout these DLLs, System.Text.Json silently fails when parsing
ProcessMappingMetadata.SymbolMetadataJSON strings during nettrace-to-ETLX conversion. This causesParsedSymbolMetadatato return null, soMatchOrInitElf()/MatchOrInitPE()are never called,symbolInfostays null, andBinaryFormatreturnsUnknown— breaking ELF symbol resolution for Linux .nettrace traces.Root Cause
PerfView embeds DLLs as
EmbeddedResourceitems inPerfView.csproj. System.Text.Json and its direct dependency System.Text.Encodings.Web were already embedded, but the transitive dependencies System.IO.Pipelines and Microsoft.Bcl.AsyncInterfaces were not. Local builds work because the output directory contains all transitive NuGet dependencies, but the official self-extracting EXE only includes explicitly listed resources.Verification
Changes
src/Directory.Packages.props: AddedSystem.IO.PipelinesandMicrosoft.Bcl.AsyncInterfacesv9.0.8src/PerfView/PerfView.csproj: AddedPackageReferencewithGeneratePathProperty="true"andEmbeddedResourceentries for both DLLsTesting