[Feature]: Allow passing in data to Evaluate function on Locator object

[matt-kxs]

🚀 Feature Request

When using page.evaluate it is possible to pass in multiple values. When using someLocator.evaluate you can only pass in SVGElement | HTMLElement. I am requesting that we update locator.evaluate to work the same way as page.evaluate

Example

const nodeId= "5";
const someLocator = this.page.frameLocator("iframe[data-test-id='someId']").locator("[data-test-id='someOtherId']");
const position = await someLocator.evaluate(
	({ nodeId }) => {
		const cy = window["getCy"]();
		const cyElement = cy.getElementById(nodeId);
		if (cyElement !== undefined && cyElement.renderedPosition !== undefined) {
			const pos = cyElement.renderedPosition();
			return { x: pos.x, y: pos.y };
		}
		throw new Error(`Node with ID ${nodeId} not found or has no rendered position.`);
	},
	{ nodeId }
);
return { x: Math.round(position.x), y: Math.round(position.y) };

Motivation

The product I'm testing has lots of iframes and nested iframes. I need an easy way to perform evaluate within the iframe context of a locator with the ability to optionally pass in data. My current workaround is to hard code the iframe locator and use evaluateHandle to convert back into a Frame object. The Frame object supports passing in variables to evaluate. This is harder to do when it's not easy or possible to determine the iframe locator at run-time (as far as I know there's no way to get a locator's frame). For example:

const frame = await getFrameFromLocator(this.page.locator("iframe:visible").first()));

[pavelfeldman]

You can pass arguments: https://playwright.dev/docs/api/class-locator#locator-evaluate-option-arg

[matt-kxs]

@pavelfeldman, passing in arguments does not work. You get a typescript warning when you try with my example that its expected to be SVGElement|HtmlElement. If you bypass the typescript warning, it does not work at run-time. In my example, nodeId is resolved as undefined if I do a console.log and inspect the browser while the test is running. This is completely resolved once I modify the code to use the Frame object instead.

[matt-kxs]

@pavelfeldman please let me know if I'm misguided or if I should log a bug instead? Based on your response it sounds like my example is supposed to work but does not.