feat(mcp): respond with snapshot diff when beneficial #37500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
feat-mcp-snapshot-diff
branch
from
6b0df62 to
ff33efa
Compare
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Sep 20, 2025
| - Page Snapshot: | ||
| \`\`\`yaml | ||
| - button "Button"`), | ||
| - Page Title: Title`), |
Member
There was a problem hiding this comment.
I'd say if the dom did not change we should not include the snapshot at all, along with url / title.
Contributor
Author
There was a problem hiding this comment.
I'll follow up in a separate PR.
Upon capturing aria snapshot for a tab, we also diff it
against a previous one. If the diff is small enough, mcp tool
responds with the diff, otherwise it includes the full snapshot.
Example response:
```
- Page Snapshot Diff:
The following refs have changed
'''yaml
button "Button 1" [active] [ref=e2]
'''
'''yaml
button "Button 2" [ref=e3]
'''
'''yaml
listitem [ref=e5]:
- text: Filler 0
- button "new button" [ref=e105]
'''
```
dgozman
force-pushed
the
feat-mcp-snapshot-diff
branch
from
ff33efa to
1273667
Compare
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
feat-mcp-snapshot-diff
branch
from
1273667 to
d69aa34
Compare
Contributor
Test results for "tests 1"2 failed 4 flaky46969 passed, 821 skipped Merge workflow run. |
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Sep 23, 2025
…oft#37500)" This reverts commit c92b9a1.
dgozman
added a commit
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon capturing aria snapshot for a tab, we also diff it against a previous one. If the diff is small enough, mcp tool responds with the diff, otherwise it includes the full snapshot.
Example response: