chore: reduce plumbing for pauseAtEnd/pauseOnError #37515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
chore-less-plumbing-on-error
branch
from
550917a to
e7d558b
Compare
dgozman
force-pushed
the
chore-less-plumbing-on-error
branch
from
e7d558b to
8ef2a6d
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"2 flaky46980 passed, 821 skipped Merge workflow run. |
pavelfeldman
approved these changes
Sep 23, 2025
packages/playwright/src/index.ts
Outdated
| (testInfo as TestInfoImpl)._onDidFinishTestFunction = async () => { | ||
| const page = playwright._allPages()[0]; | ||
| if (page) | ||
| await runBrowserBackendAtEnd(page, testInfo.errors[0]?.message); |
Member
There was a problem hiding this comment.
I would not pass anything here and keep all the magic in the runBrowserBackend method. Maybe you want to include all pages there.
packages/playwright/src/index.ts
Outdated
|
|
||
| const artifactsRecorder = new ArtifactsRecorder(playwright, tracing().artifactsDir(), screenshot); | ||
| (testInfo as TestInfoImpl)._onDidFinishTestFunction = async () => { | ||
| const page = playwright._allPages()[0]; |
Member
There was a problem hiding this comment.
I don't think we should ever do this, non-fixture path should be strongly discouraged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.