-
Notifications
You must be signed in to change notification settings - Fork 5k
chore: perform agent turn event #38535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7c6dd63 to
9c17585
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
docs/src/api/params.md
Outdated
| - `model` <[string]> Model identifier within provider. | ||
| - `cacheFile` ?<[string]> Cache file to use/generate code for performed actions into. Cache is not used if not specified (default). | ||
| - `cacheMode` ?<['force'|'ignore'|'auto']> Cache control, defaults to 'auto'. | ||
| - `cacheMode` ?<['force'|'ignore'|'update'|'auto']> Cache control, defaults to 'auto'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a name for the enum, we are gonna need it in the ports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll follow up, but let's add it into the doc lint?
| const intent = assistantMessage.content.filter(c => c.type === 'text').map(c => c.text).join('\n'); | ||
| page.emit(Page.Events.AgentTurn, { role: 'assistant', message: intent, usage }); | ||
| const toolCalls = assistantMessage.content.filter(c => c.type === 'tool_call'); | ||
| page.emit(Page.Events.AgentTurn, { role: 'assistant', message: `no tool calls`, usage }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing if ?
tests/library/perform-task.spec.ts
Outdated
| model: 'claude-sonnet-4.5', | ||
| cachePathTemplate: '{testFilePath}-cache.json', | ||
| cacheMode: process.env.CI ? 'force' : 'auto', | ||
| provider: 'anthropic', // 'github', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
|
||
| test('page.perform', async ({ page, server }) => { | ||
| await page.goto(server.PREFIX + '/evals/fill-form.html'); | ||
| page.on('agentturn', turn => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's here for a reason.
07c163a to
215cac8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
215cac8 to
218dbab
Compare
Test results for "MCP"4 failed 2710 passed, 116 skipped Merge workflow run. |
Test results for "tests 1"6 failed 3 flaky34359 passed, 688 skipped Merge workflow run. |
No description provided.