chore: zod 4 #38809

Skn0tt · 2026-01-16T11:29:01Z

updates internal zod usage to zod v4, so we can leverage the built-in json schema converter and the prettifyErrors function
ensures external support for both zod 3 and zod 4
removes zod from utilsBundle so we don't ship it double

Skn0tt · 2026-01-16T15:32:43Z

utils/generate_types/test/tsconfig.json

    "target": "ESNext",
    "noEmit": true,
    "moduleResolution": "node",
+    "allowSyntheticDefaultImports": true


zod v4 needs this set because its declaration files use syntax that depends on it. without it, there's a type checking error. Users that have zod v4 installed will already have this, and users without zod v4 will not need it, so this change is fine.

packages/playwright-core/src/mcpBundle.ts

yury-s · 2026-01-16T16:29:42Z

packages/playwright-core/bundles/mcp/package.json

    "@lowire/loop": "^0.0.23",
    "@modelcontextprotocol/sdk": "^1.25.2",
-    "zod": "^3.25.76",
+    "zod": "^4.3.5",


Please measure the bundle compilation time and the output size (e.g. ls -lh packages/playwright-core/lib/mcpBundleImpl/index.js) with old/new version. Rolling sdk and zod without any hack for sdk would leave in a bad state (see modelcontextprotocol/typescript-sdk#1313), let's make sure this doesn't regress because of the zod.

old

886k

==== Running esbuild: packages/playwright-core/bundles/mcp/src/mcpBundleImpl.ts Package contribution to bundle: zod 119.9 KB 29.35% ajv 102.0 KB 24.97% @modelcontextprotocol/sdk 97.1 KB 23.77% @lowire/loop 23.5 KB 5.75% zod-to-json-schema 20.3 KB 4.98% ajv-formats 9.9 KB 2.42% fast-uri 9.3 KB 2.27% @hono/node-server 7.7 KB 1.88% eventsource 5.2 KB 1.27% cross-spawn 2.9 KB 0.70% content-type 1.9 KB 0.46% eventsource-parser 1.8 KB 0.44% isexe 1.5 KB 0.37% which 1.4 KB 0.35% json-schema-traverse 1.2 KB 0.30% bytes 1.0 KB 0.26% pkce-challenge 0.8 KB 0.20% fast-deep-equal 0.7 KB 0.18% path-key 0.2 KB 0.06% shebang-command 0.2 KB 0.05% shebang-regex 0.1 KB 0.01% ==== Done in 114 ms

new

666K

==== Running esbuild: packages/playwright-core/bundles/mcp/src/mcpBundleImpl.ts Package contribution to bundle: zod 374.6 KB 56.46% ajv 102.2 KB 15.40% @modelcontextprotocol/sdk 97.1 KB 14.64% @lowire/loop 23.5 KB 3.54% zod-to-json-schema 20.4 KB 3.07% ajv-formats 9.9 KB 1.49% fast-uri 9.3 KB 1.40% @hono/node-server 7.7 KB 1.16% eventsource 5.2 KB 0.79% cross-spawn 2.9 KB 0.43% content-type 1.9 KB 0.28% eventsource-parser 1.8 KB 0.27% isexe 1.5 KB 0.23% which 1.4 KB 0.22% json-schema-traverse 1.2 KB 0.18% bytes 1.0 KB 0.16% pkce-challenge 0.8 KB 0.12% fast-deep-equal 0.7 KB 0.11% path-key 0.2 KB 0.03% shebang-command 0.2 KB 0.03% shebang-regex 0.1 KB 0.01% ==== Done in 132 ms

The size is shrinking, yay!

i did something wrong when measuring. it now shows 411K on main, so the size actually grew

packages/playwright-core/bundles/mcp/src/mcpBundleImpl.ts

yury-s · 2026-01-16T16:54:44Z

packages/playwright/src/mcp/browser/browserServerBackend.ts

    if (!tool)
      throw new Error(`Tool "${name}" not found`);
-    const parsedArguments = tool.schema.inputSchema.parse(rawArguments || {});
+    const parsedArguments = tool.schema.inputSchema.parse(rawArguments || {}) as any;


Why do we need this?

this used to be any, now it's unknown. we're casting it back so we can use it

yury-s · 2026-01-16T16:57:01Z

tests/library/agent-perform.spec.ts

 });

-test('retrieve a secret', async ({ context }) => {
+// cannot get it to work reliably in CI


Should it be skip then or is it failing locally too?

But I'd rather we made it work.

it's failing locally too, wrong comment. i'll make it work in a followup

yury-s · 2026-01-16T16:58:12Z

utils/generate_types/overrides.d.ts

+import { ZodTypeAny, z } from 'zod';
 // @ts-ignore this will be any if zod is not installed
-type ZodInfer<T extends ZodTypeAny> = import('zod').infer<T>;
+import * as z3 from 'zod/v3';


Is there zod/v3 in v3 zod?

no, it'll be any. but the other one exists, so everything works :D

github-actions · 2026-01-16T18:05:35Z

Test results for "MCP"

4 failed
❌ [chromium] › mcp/launch.spec.ts:21 › test reopen browser @mcp-macos-15
❌ [firefox] › mcp/test-debug.spec.ts:48 › test_debug (pause/resume) @mcp-macos-15
❌ [firefox] › mcp/test-debug.spec.ts:167 › test_debug (pause/snapshot/resume) @mcp-macos-15
❌ [firefox] › mcp/test-debug.spec.ts:234 › test_debug / evaluate x 2 @mcp-macos-15

2826 passed, 121 skipped

Merge workflow run.

github-actions · 2026-01-16T18:55:26Z

Test results for "tests 1"

26 failed
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node22
❌ [firefox-library] › library/agent-expect.spec.ts:223 › expectURL success @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:261 › expectURL with regex @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @firefox-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:223 › expectURL success @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:261 › expectURL with regex @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @webkit-ubuntu-22.04-node20
❌ [playwright-test] › playwright.spec.ts:877 › page.pause() should disable test timeout @macos-latest-node20
❌ [playwright-test] › runner.spec.ts:124 › should ignore subprocess creation error because of SIGINT @macos-latest-node20

4 flaky

⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:688 › should indicate current test status `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-test-tree.spec.ts:407 › should collapse all `@windows-latest-node20`

34567 passed, 691 skipped

Merge workflow run.

chore: zod 4

40216b4

Skn0tt requested a review from dgozman January 16, 2026 11:29

Skn0tt self-assigned this Jan 16, 2026

dgozman requested a review from yury-s January 16, 2026 11:39

fix types

820b4ec

This comment has been minimized.

Sign in to view

simplify

a8fa479

This comment has been minimized.

Sign in to view

Skn0tt added 2 commits January 16, 2026 15:09

use v4 tojsonschema

d080865

list zod as peer

bb5b8d2

This comment has been minimized.

Sign in to view

update tests because of slightly different schema

bb6c2c5

This comment has been minimized.

Sign in to view

fix tests

f19c25a

Skn0tt commented Jan 16, 2026

View reviewed changes

Skn0tt added 2 commits January 16, 2026 16:42

Merge branch 'main' into zod-4

957623e

update two other tests

aea6fb8

This comment has been minimized.

Sign in to view

yury-s reviewed Jan 16, 2026

View reviewed changes

dont use /v4

a063d44

yury-s approved these changes Jan 16, 2026

View reviewed changes

Skn0tt added 3 commits January 16, 2026 18:01

update comment

5b1696b

Merge branch 'main' into zod-4

4f3d02d

update caches

f9197e6

This comment has been minimized.

Sign in to view

Skn0tt merged commit 0d2dec0 into microsoft:main Jan 16, 2026
19 of 32 checks passed

This was referenced Jan 16, 2026

[Ports]: Backport client side changes for 1.58 microsoft/playwright-python#3010

Open

[Ports]: Backport client side changes for 1.58 microsoft/playwright-java#1869

Open

[Ports]: Backport client side changes for 1.58 microsoft/playwright-dotnet#3262

Open

chore: zod 4 #38809

chore: zod 4 #38809

Uh oh!

Conversation

Skn0tt commented Jan 16, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Skn0tt Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

old

new

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Skn0tt Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Skn0tt Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Uh oh!

github-actions bot commented Jan 16, 2026

Test results for "MCP"

Uh oh!

github-actions bot commented Jan 16, 2026

Test results for "tests 1"

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Skn0tt Jan 16, 2026 •

edited

Loading

Skn0tt Jan 16, 2026 •

edited

Loading

Skn0tt Jan 16, 2026 •

edited

Loading