chore: extract src/tools#39632
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom Mar 11, 2026
Merged
Conversation
pavelfeldman
force-pushed
the
extract_tools_1
branch
2 times, most recently
from
fcd071b to
a7015f3
Compare
yury-s
approved these changes
Mar 11, 2026
dgozman
approved these changes
Mar 11, 2026
pavelfeldman
force-pushed
the
extract_tools_1
branch
from
a7015f3 to
231296f
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "MCP"3 failed 5241 passed, 164 skipped Merge workflow run. |
Contributor
Test results for "tests 1"4 flaky38698 passed, 846 skipped Merge workflow run. |
bgilly
added a commit
to bgilly/playwright
that referenced
this pull request
Apr 11, 2026
killAllDaemons grepped process command lines for 'cli-daemon', 'run-mcp-server', and 'run-cli-server'. None of these match real daemons today: - 'cli-daemon' was intended to match the cliDaemon.js entry point added in microsoft#39632 but the case is wrong (camelCase vs hyphenated). - 'run-mcp-server' and 'run-cli-server' were argv tokens from the pre-microsoft#39632 daemon launch mechanism. They no longer appear in any process command line. Only the dashboardApp.js pattern added in microsoft#40004 matched anything. Replace the three dead patterns with 'cliDaemon.js'. Verified empirically on macOS: kill-all now kills real orphan daemons where it previously reported "No daemon processes found." Fixes microsoft#40165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.