fix(firefox): commit navigation before init scripts#40133
Open
JustasMonkev wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(firefox): commit navigation before init scripts#40133JustasMonkev wants to merge 1 commit intomicrosoft:mainfrom
JustasMonkev wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Member
|
// CC @aslushnikov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the Firefox/Juggler ordering issue from #39624.
Before this change, Firefox could create the new document execution context and run init scripts before
Page.navigationCommittedwas reported. Because of that, MCP could observe init script console messages before the navigation commit.This change updates the Firefox Juggler frame lifecycle so new-document init scripts run after the navigation commit is reported. It also avoids committing the initial synthetic
about:blankwhile a real navigation is still pending.The tests were updated to check the new behavior directly:
Testing
Tested against a patched Firefox app copy with the updated
FrameTree.jsinomni.ja.PLAYWRIGHT_MCP_EXECUTABLE_PATH=/tmp/pwff39624.YQBUwG/Nightly.app/Contents/MacOS/firefox npm run test-mcp -- --project=firefox tests/mcp/init-script.spec.tsCI=1 FFPATH=/tmp/pwff39624.YQBUwG/Nightly.app/Contents/MacOS/firefox npm run test -- --project=firefox-page tests/page/page-add-init-script.spec.ts