test(heap): run heap leak tests across all browsers#41069
Open
dgozman wants to merge 2 commits into
Open
Conversation
Move heap.spec.ts into tests/library, force a fresh worker for a clean heap, and enable it for chromium, firefox and webkit. Inline the queryObjectCount helper into the test file. Bump the BrowserContext and Browser server-side object counts to account for the new WVBrowserContext subclass.
Inline queryObjectCount, force a separate worker for a clean heap, drop the chromium-only skip, and bump the BrowserContext/Browser counts for the new WVBrowserContext subclass.
Contributor
Test results for "MCP"7233 passed, 1113 skipped Merge workflow run. |
Contributor
Test results for "tests 1"5 flaky44057 passed, 864 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
heap.spec.tsfromtests/stressintotests/libraryand force a fresh worker (clean heap), likeandroid.spec.tsqueryObjectCounthelper into the test file and drop the now-unusedtests/config/queryObjects.tsBrowserContext/Browsercounts to 6 for the newWVBrowserContextsubclass