Skip to content

fix(mcp): pass action timeout to browser_wait_for waitFor calls #41270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 1 commit into from
Jun 12, 2026
Merged

fix(mcp): pass action timeout to browser_wait_for waitFor calls #41270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/playwright-core/src/tools/backend/wait.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ const wait = defineTool({

if (goneLocator) {
response.addCode(`await page.getByText(${JSON.stringify(params.textGone)}).first().waitFor({ state: 'hidden' });`);
await goneLocator.waitFor({ state: 'hidden' });
await goneLocator.waitFor({ state: 'hidden', ...tab.actionTimeoutOptions });
}

if (locator) {
response.addCode(`await page.getByText(${JSON.stringify(params.text)}).first().waitFor({ state: 'visible' });`);
await locator.waitFor({ state: 'visible' });
await locator.waitFor({ state: 'visible', ...tab.actionTimeoutOptions });
}

response.addTextResult(`Waited for ${params.text || params.textGone || params.time}`);
Expand Down
50 changes: 50 additions & 0 deletions tests/mcp/timeouts.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,56 @@ test('action timeout (custom)', async ({ startClient, server }) => {
});
});

test('wait_for text timeout', async ({ startClient, server }) => {
const { client } = await startClient({ args: [`--timeout-action=1234`] });
server.setContent('/', `
<!DOCTYPE html>
<html>
<div>Hello World</div>
</html>
`, 'text/html');

await client.callTool({
name: 'browser_navigate',
arguments: {
url: server.PREFIX,
},
});

expect(await client.callTool({
name: 'browser_wait_for',
arguments: { text: 'This text will never appear' },
})).toHaveResponse({
error: expect.stringContaining(`Timeout 1234ms exceeded.`),
isError: true,
});
});

test('wait_for textGone timeout', async ({ startClient, server }) => {
const { client } = await startClient({ args: [`--timeout-action=1234`] });
server.setContent('/', `
<!DOCTYPE html>
<html>
<div>Permanent text</div>
</html>
`, 'text/html');

await client.callTool({
name: 'browser_navigate',
arguments: {
url: server.PREFIX,
},
});

expect(await client.callTool({
name: 'browser_wait_for',
arguments: { textGone: 'Permanent text' },
})).toHaveResponse({
error: expect.stringContaining(`Timeout 1234ms exceeded.`),
isError: true,
});
});

test('navigation timeout', async ({ startClient, server }) => {
const { client } = await startClient({ args: [`--timeout-navigation=1234`] });
server.setRoute('/slow', async () => {
Expand Down
Loading