Skip to content

cherry-pick(#41309, #43149): Revert "fix(firefox): treat navigationCommitted events without navigationId as same-document URL updates (#41224)" #41350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 2 commits into from
Jun 18, 2026
Merged

cherry-pick(#41309, #43149): Revert "fix(firefox): treat navigationCommitted events without navigationId as same-document URL updates (#41224)" #41350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89e4b13
test: mark test added in PR#41224 as slow (#41309)
dcrousso Jun 15, 2026
992ae9d
Revert "fix(firefox): treat `navigationCommitted` events without `nav…
dcrousso Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions packages/playwright-core/src/server/firefox/ffPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,18 +239,11 @@ export class FFPage implements PageDelegate {
}

_onNavigationCommitted(params: Protocol.Page.navigationCommittedPayload) {
if (!params.navigationId) {
// Firefox replays the current navigation without a navigationId during a process swap (e.g. when restoring a persistent profile).
// Treat these as same-document URL updates so they don't interrupt any in-flight new-document navigation in Frame.gotoImpl.
this._page.frameManager.frameCommittedSameDocumentNavigation(params.frameId, params.url);
return;
}

for (const [workerId, worker] of this._workers) {
if (worker.frameId === params.frameId)
this._onWorkerDestroyed({ workerId });
}
this._page.frameManager.frameCommittedNewDocumentNavigation(params.frameId, params.url, params.name || '', params.navigationId, false);
this._page.frameManager.frameCommittedNewDocumentNavigation(params.frameId, params.url, params.name || '', params.navigationId || '', false);
}

_onSameDocumentNavigation(params: Protocol.Page.sameDocumentNavigationPayload) {
Expand Down
5 changes: 4 additions & 1 deletion tests/library/defaultbrowsercontext-2.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,10 @@ it('should create userDataDir if it does not exist', async ({ createUserDataDir,

it('should goto about:blank on relaunched persistent context', {
annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/41216' },
}, async ({ browserType, createUserDataDir }) => {
}, async ({ browserType, createUserDataDir, browserName }) => {
it.fixme(browserName === 'firefox');
it.slow();

const userDataDir = await createUserDataDir();

const context1 = await browserType.launchPersistentContext(userDataDir);
Expand Down
Loading