Skip to content

fix(mcp): list a failed network request only once - #41481

Merged
dcrousso merged 1 commit into
microsoft:mainfrom
dcrousso:fix-mcp-network-double-count
Jun 26, 2026
Merged

fix(mcp): list a failed network request only once#41481
dcrousso merged 1 commit into
microsoft:mainfrom
dcrousso:fix-mcp-network-double-count

Conversation

@dcrousso

Copy link
Copy Markdown
Contributor

_handleRequest already records every request (and _handleResponse does not re-add it)

`_handleRequest` already records every request (and `_handleResponse` does not re-add it)
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [firefox] › mcp/http.spec.ts:349 › client should receive list roots request @mcp-ubuntu-latest-firefox
❌ [firefox] › mcp/http.spec.ts:349 › client should receive list roots request @mcp-macos-latest-firefox
❌ [webkit] › mcp/http.spec.ts:349 › client should receive list roots request @mcp-ubuntu-latest-webkit

7419 passed, 1132 skipped


Merge workflow run.

@dcrousso
dcrousso merged commit 8b25dff into microsoft:main Jun 26, 2026
14 of 18 checks passed
@dcrousso
dcrousso deleted the fix-mcp-network-double-count branch June 26, 2026 19:02
pavelfeldman added a commit to microsoft/playwright-mcp that referenced this pull request Jun 29, 2026
## What's New

### Tool Improvements

- **`browser_take_screenshot` — `scale` option** — Choose between
CSS-pixel screenshots (smaller, device-consistent) and device-pixel
screenshots (high resolution)
([#41465](microsoft/playwright#41465))
- **Configurable heartbeat timeout** — The heartbeat ping timeout is now
configurable
([#41391](microsoft/playwright#41391))

## Bug Fixes

- Redact secrets in console log artifacts
([#41515](microsoft/playwright#41515))
- Never include `data:` URL payloads in snapshot or network output
([#41450](microsoft/playwright#41450))
- List a failed network request only once
([#41481](microsoft/playwright#41481))
- Wait for the next pause or context closure in `browser_resume`
([#41293](microsoft/playwright#41293))
- Pass the action timeout to `browser_wait_for` waitFor calls
([#41270](microsoft/playwright#41270))
- Check the tracing state before stopping in `browser_stop_tracing`
([#41040](microsoft/playwright#41040))
- Assign caps as an array for the legacy `--vision` flag
([#41253](microsoft/playwright#41253))
- Use optional chaining for the nullable browser on disposal
([#41237](microsoft/playwright#41237))
- Add a missing `.catch()` on the sessionLog write queue
([#41234](microsoft/playwright#41234))
PM-Labs pushed a commit to pmlabs-org/mcp-playwright that referenced this pull request Jul 9, 2026
## What's New

### Tool Improvements

- **`browser_take_screenshot` — `scale` option** — Choose between
CSS-pixel screenshots (smaller, device-consistent) and device-pixel
screenshots (high resolution)
([#41465](microsoft/playwright#41465))
- **Configurable heartbeat timeout** — The heartbeat ping timeout is now
configurable
([#41391](microsoft/playwright#41391))

## Bug Fixes

- Redact secrets in console log artifacts
([#41515](microsoft/playwright#41515))
- Never include `data:` URL payloads in snapshot or network output
([#41450](microsoft/playwright#41450))
- List a failed network request only once
([#41481](microsoft/playwright#41481))
- Wait for the next pause or context closure in `browser_resume`
([#41293](microsoft/playwright#41293))
- Pass the action timeout to `browser_wait_for` waitFor calls
([#41270](microsoft/playwright#41270))
- Check the tracing state before stopping in `browser_stop_tracing`
([#41040](microsoft/playwright#41040))
- Assign caps as an array for the legacy `--vision` flag
([#41253](microsoft/playwright#41253))
- Use optional chaining for the nullable browser on disposal
([#41237](microsoft/playwright#41237))
- Add a missing `.catch()` on the sessionLog write queue
([#41234](microsoft/playwright#41234))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants