fix(electron): close pages from the main process to avoid Target.closeTarget hang#41695
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Jul 8, 2026
yury-s
force-pushed
the
test-electron-teardown-hang
branch
from
July 9, 2026 22:43
13d604f to
7df6703
Compare
yury-s
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…eTarget hang page.close() sends CDP Target.closeTarget and waits for the browser-level Target.detachedFromTarget event to resolve. On Electron, when the close races a navigation that is being committed, Electron acks Target.closeTarget with success but silently drops the actual close, so the target is never destroyed and page.close() hangs forever (Electron has no unload watchdog to recover, unlike Chrome). Close the page from the main process instead via a per-page custom close handler that calls webContents.close(). This is not subject to the CDP/ navigation race, and webContents.close() (without waitForBeforeUnload) closes without running beforeunload, matching page.close(runBeforeUnload: false) semantics.
yury-s
force-pushed
the
test-electron-teardown-hang
branch
from
July 10, 2026 01:00
7df6703 to
f17a470
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Jul 10, 2026
- PLAYWRIGHT_ELECTRON_LEGACY_PAGE_CLOSE opts back into Target.closeTarget. - Fall back to the default close when the webContents cannot be found. - Clarify why we close the webContents rather than the BrowserWindow.
dgozman
approved these changes
Jul 10, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
page.close({ runBeforeUnload: true }) went through the CDP Page.close path,
which has the same problem as Target.closeTarget on Electron: it leaves a
window with a pending navigation open. Pass runBeforeUnload to the custom
close handler and map it to webContents.close({ waitForBeforeUnload }), so
both close variants close from the main process.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "MCP"3 failed 7757 passed, 1249 skipped Merge workflow run. |
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"8 flaky49516 passed, 1161 skipped Merge workflow run. |
Contributor
Test results for "tests 2"1 failed 32 flaky105882 passed, 4474 skipped Merge workflow run. |
|
@yury-s I haven't managed to create a minimal reproduction yet (so haven't filed a bug yet), but I'm running into this on Chromium too. According to my testing the race also exists in Chromium and was introduced there before the version that Electron 42.4.1 is based on. I think this corresponds to https://issues.chromium.org/issues/536385539. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page.close()sends CDPTarget.closeTargetand resolves only on the browser-levelTarget.detachedFromTargetevent. On Electron, when the close races a navigation that is being committed, Electron acksTarget.closeTargetwithsuccessbut silently drops the actual close, so the target is never destroyed andpage.close()hangs forever (Electron has no unload watchdog to recover, unlike Chrome). This surfaced as flaky Electron teardown timeouts in CI (e.g.page-autowaiting-no-hang.spec.ts"assigning location to about:blank").webContents.close(), which is not subject to the CDP/navigation race.webContents.close()(withoutwaitForBeforeUnload) closes without runningbeforeunload, matchingpage.close(runBeforeUnload: false)force-close semantics.