fix(chromium): do not modify Origin header across a redirect#41700
Closed
aydinomer00 wants to merge 1 commit into
Closed
fix(chromium): do not modify Origin header across a redirect#41700aydinomer00 wants to merge 1 commit into
aydinomer00 wants to merge 1 commit into
Conversation
Continuing a redirected request re-sent the pre-redirect Origin header. Chromium 149+ (BlockOriginHeaderModificationOnRedirect) treats that as a modification and fails the request with net::ERR_INVALID_ARGUMENT. Drop the Origin from the continued request so the browser keeps the Origin it computed for the redirected request. Fixes microsoft#41690
Member
|
See #41696 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Originheader. Chromium 149+ (BlockOriginHeaderModificationOnRedirect) treats that as a modification and fails the request withnet::ERR_INVALID_ARGUMENT, soroute.continue()across a cross-origin redirect broke.Originfrom the continued request on the redirect path so the browser keeps the Origin it computed for the redirected request.Fixes #41690