Skip to content

test(heap): fixme "should not leak workers" on stable Firefox #41749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
microsoft-playwright-automation wants to merge 1 commit into from
Closed

test(heap): fixme "should not leak workers" on stable Firefox #41749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/library/heap.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,11 @@ test('should not leak dispatchers after closing page', async ({ context, server
expect(await queryObjectCount(clientClass.Response)).toBe(0);
});

test('should not leak workers', async ({ page }) => {
test('should not leak workers', async ({ page, browserName, channel }) => {
// Flaky on stable Firefox (Juggler): after worker.terminate(), the worker 'close'
// event is sometimes never delivered, so workerObj.waitForEvent('close') hangs and
// the test times out. Passes on Chromium, WebKit and moz-firefox-nightly (BiDi).
test.fixme(browserName === 'firefox' && !channel?.startsWith('moz-firefox'));
const before = await queryObjectCount(coreServer.Worker);
for (let i = 0; i < 5; ++i) {
const [workerHandle, workerObj] = await Promise.all([
Expand Down
Loading