fix(mcp): auto-reconnect extension relay after disconnect#41875
Open
sgewirtz1 wants to merge 1 commit into
Open
fix(mcp): auto-reconnect extension relay after disconnect#41875sgewirtz1 wants to merge 1 commit into
sgewirtz1 wants to merge 1 commit into
Conversation
When the browser extension disconnects (MV3 service worker idle timeout, browser restart, extension reload), reset the connection promise and re-open connect.html so the relay reconnects automatically. Guard with _stopped so intentional stop() calls do not trigger reconnect. Store _clientName in establishExtensionConnection so it is available to the reconnect path without requiring a new caller argument. Fixes microsoft#41874
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41874
Problem
When the browser extension disconnects from the MCP relay (Chrome MV3 service worker idle timeout ~5 min, browser restart, extension reload), the relay leaves
_extensionConnectionnull and never re-opensconnect.html. Every subsequent MCP tool call fails withExtension not connected; the only recovery is restarting the entire MCP server.Fix
In
_handleExtensionConnection.onclose:_extensionConnection(so a reconnecting extension is not rejected by the "already established" guard)_extensionConnectionPromiseto a freshManualPromise_openConnectPageInBrowserto re-spawn the connect tabTwo supporting changes:
_clientNameis stored whenestablishExtensionConnectionis first called, so the reconnect path has the client name without requiring a new caller argument_stoppedflag is set instop()to prevent reconnect attempts after intentional shutdown