Skip to content

fix(firefox): do not override Accept-Language header set by the page#41886

Merged
yury-s merged 1 commit into
microsoft:mainfrom
yury-s:fix-23732
Jul 20, 2026
Merged

fix(firefox): do not override Accept-Language header set by the page#41886
yury-s merged 1 commit into
microsoft:mainfrom
yury-s:fix-23732

Conversation

@yury-s

@yury-s yury-s commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

  • Do not merge the locale-derived Accept-Language header into Firefox extra HTTP headers — the browser-side language override already produces the header, and the extra-header mechanism was clobbering an Accept-Language explicitly set on a fetch/XHR request.
  • Add a test that an explicit Accept-Language on a fetch is preserved and that the locale-derived one is still sent when the request does not specify it. Marked fixme on WebKit until the corresponding browser fix rolls.

References #23732 (fixes the Firefox part; WebKit needs a separate fix).

@yury-s
yury-s requested review from dcrousso and pavelfeldman July 20, 2026 22:01
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

3 flaky ⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:388 › should reveal errors in the sourcetab `@windows-latest-node22`

49973 passed, 1189 skipped


Merge workflow run.

@yury-s
yury-s merged commit 8cd58ba into microsoft:main Jul 20, 2026
46 of 47 checks passed
@yury-s
yury-s deleted the fix-23732 branch July 20, 2026 22:42
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [webkit] › mcp/annotate.spec.ts:110 › should abort annotation when last screenshot is removed @mcp-macos-latest-webkit
❌ [webkit] › mcp/annotate.spec.ts:173 › user-initiated annotate downloads zip with feedback.md @mcp-macos-latest-webkit

7758 passed, 1249 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures.

🟢 The failures are pre-existing flakes — this PR is clear

The only two failures are mcp/annotate.spec.ts on WebKit, and this PR touches Firefox ffBrowser.ts plus a locale test — nothing in the MCP annotate path. Both tests flip verdict across runs on SHAs this PR can't be responsible for.

Details

Pre-existing flake / infra

The PR's diff is confined to the Firefox Accept-Language header logic and browsercontext-locale.spec.ts; the MCP annotate flow exercises neither. The tests 1 report had only 3 flaky (no failures).

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants