fix(mcp): identify downloads explicitly#41933
Conversation
Chromium reports both downloads and renderer crashes as ERR_ABORTED. Wait for either event so crash recovery cannot race the next tool call. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0d6d0323-d581-4df1-ae11-bf2d9302c1d2
This comment has been minimized.
This comment has been minimized.
|
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟢 The one failure is a pre-existing flake — this PR is clearThe single red test, DetailsPre-existing flake / infra
On the diff itself Worth noting your change does touch this exact code path — I'm a first pass, so treat the green as "no PR-caused failures found," not a guarantee the branch is bug-free. Triaged by the Playwright bot - agent run |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 296e429d-05c3-4f64-be3f-a199a1e00d65
Test results for "MCP"7786 passed, 1262 skipped Merge workflow run. |
This PR stops treating every Chromium
net::ERR_ABORTEDnavigation as a possible download. Since Chromium 140, released in September 2025,Page.navigatereports downloads explicitly, which Playwright surfaces asDownload is starting.Previously, MCP waited up to three seconds for a download event before returning
net::ERR_ABORTED. This didn’t change the result, but happened to give the renderer’scrashevent time to arrive. The error is now returned immediately. Crash recovery stays the same: once the event arrives, a subsequent MCP call resets the page toabout:blankand reportsPage crashed and was reset to about:blank.The crash tests now poll for recovery instead of relying on the download wait, and explicitly await the crash event when asserting tab state.