Skip to content

Revert "feat(routeFromHar): add interceptAPIRequests option (#41294)"#41964

Merged
dcrousso merged 1 commit into
microsoft:mainfrom
dcrousso:revert-41294
Jul 23, 2026
Merged

Revert "feat(routeFromHar): add interceptAPIRequests option (#41294)"#41964
dcrousso merged 1 commit into
microsoft:mainfrom
dcrousso:revert-41294

Conversation

@dcrousso

Copy link
Copy Markdown
Contributor

No description provided.

revert microsoft#41294 which added the `interceptAPIRequests` option to `routeFromHAR`

with the option gone, `page.request` and `context.request` calls always hit the network instead of being served from a HAR file, matching the behavior before `v1.62`

- regenerate `channels.d.ts`, `validator.ts`, `protocolMetainfo.ts`, and `types.d.ts` from the reverted `browserContext.yml` spec and docs

- drop the now-unused `kNoTimeout` import in `harRouter.ts` that a later commit added only for the reverted code
@dcrousso dcrousso changed the title Revert "feat(routeFromHar): add interceptAPIRequests option" Revert "feat(routeFromHar): add interceptAPIRequests option (#41294)" Jul 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

4 flaky ⚠️ [chromium-library] › library/chromium/chromium.spec.ts:371 › should produce network events, routing, and annotations for Service Worker `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-goto.spec.ts:81 › should work with Cross-Origin-Opener-Policy `@firefox-ubuntu-22.04-node20`

50269 passed, 1190 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/cli-devtools.spec.ts:84 › request shows full request and response details @mcp-windows-latest-firefox

7794 passed, 1266 skipped


Merge workflow run.

@dcrousso
dcrousso merged commit a92a7a3 into microsoft:main Jul 23, 2026
49 of 50 checks passed
@dcrousso
dcrousso deleted the revert-41294 branch July 23, 2026 20:48
@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures.

🟢 The one failure is a pre-existing flake — this PR is clear

[firefox] › mcp/cli-devtools.spec.ts:84 › request shows full request and response details (mcp-windows-latest-firefox) has failed on runs this PR can't be responsible for, and this revert doesn't touch the MCP request-display path.

Details

Two reports came back: "tests 1" had 0 failures (4 flaky, rescued on retry — nothing to triage), and "MCP" had the single failure below.

Pre-existing flake / infra

  • [firefox] › mcp/cli-devtools.spec.ts:84 › request shows full request and response details — flake. In the aggregated CI DB this firefox test failed 2 of 432 runs, and one of those (run 30002550614, sha 4b0cc99) is a push with no PR attached, so this PR can't be the cause. The same test also failed once on msedge under an unrelated PR fix(registry): evaluate defaultCacheDirectory lazily #41942 (run 30030184638). On top of that, this PR reverts routeFromHar's interceptAPIRequests option (fetch.ts, harBackend.ts, localUtils.ts, HAR routing) — the MCP request/requests CLI reads live page network events, not HAR routing, so the diff doesn't reach this test.

Triaged by the Playwright bot - agent run

dcrousso added a commit that referenced this pull request Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants