fix(mcp extension): look for extension profile in default user data dir#41972
Closed
sazzadsadib wants to merge 2 commits into
Closed
fix(mcp extension): look for extension profile in default user data dir#41972sazzadsadib wants to merge 2 commits into
sazzadsadib wants to merge 2 commits into
Conversation
Signed-off-by: Md. Sazzad Ur Rahman <sazzadsadib@gmail.com>
…extension profile Signed-off-by: Md. Sazzad Ur Rahman <sazzadsadib@gmail.com>
Author
|
@microsoft-github-policy-service agree |
Contributor
|
im pretty sure this was fixed in #41939 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the silent hang from microsoft/playwright-mcp#1571
running with
--extensionand no--user-data-dir, the relay spawns chrome without--profile-directory, so connect.html opens in the last used profile. if the extension lives in a different profile the page never loads andestablishExtensionConnection()waits forever with no error.this adds a
defaultUserDataDir(channel)helper returning the standard chrome/edge user data folder per OS, used as fallback so the existing profile lookup actually runs on default setups. no behavior change if you pass your own dir. unknown channels fall back to old behavior.