Skip to content

fix(tsconfig): do not throw when "extends"/"references" cannot be resolved - #42005

Merged
dgozman merged 1 commit into
microsoft:mainfrom
dgozman:fix-41989
Jul 27, 2026
Merged

fix(tsconfig): do not throw when "extends"/"references" cannot be resolved#42005
dgozman merged 1 commit into
microsoft:mainfrom
dgozman:fix-41989

Conversation

@dgozman

@dgozman dgozman commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Reverts the hard error from fix(tsconfig): fail loudly when extends/references can't be resolved #41571 (docs change kept): our tsconfig resolution does not repeat the whole process tsc has (node_modules walk-up, package.json "exports" maps, directory-form project references), so unresolved "extends"/"references" are silently ignored again, with a TODO to implement tsc-compatible resolution.
  • Adds regression tests for all reports in the issues.

Fixes #41989
Fixes #41998

…olved

We deliberately do not throw because we do not want to repeat the whole
resolution process that tsc has: node_modules walk-up, package.json
"exports" maps, directory-form project references. This reverts microsoft#41571,
keeping its docs change.

Fixes: microsoft#41989
Fixes: microsoft#41998
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium-library] › library/video.spec.ts:356 › screencast › should work for popups `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:495 › screencast › should capture static page in persistent context @smoke `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-goto.spec.ts:81 › should work with Cross-Origin-Opener-Policy `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-test-output.spec.ts:118 › should collapse repeated console messages for test `@windows-latest-node22`

50724 passed, 1190 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/dashboard.spec.ts:108 › should activate session when show is called with -s @mcp-windows-latest-firefox

7807 passed, 1266 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 CI is clear — the one failure is a known pre-existing flake

Hi, I'm the Playwright bot and I triaged the CI failures here.

This PR only touches tsconfig extends/references resolution (tsconfig-loader.ts + resolver.spec.ts). The single failing test is an MCP dashboard test that never exercises that code path, and it flakes on the same bot across many unrelated PRs. Nothing here looks caused by this PR.

Details

Overall: 1 failure, on the MCP suite only; tests 1 reported 7 flaky and 0 real failures. The diff is confined to test-runner tsconfig resolution and doesn't reach any MCP or accessibility code.

Pre-existing flake / infra

Recent final-verdict history for this test on mcp-windows-latest-firefox (oldest→newest, 🟩 pass / 🟥 fail):

🟩🟥🟩🟥🟩🟩🟥🟥🟩🟥🟥🟩🟥🟥🟩🟥🟩🟥🟩🟥🟩🟥🟥🟥🟥🟥

Flaky (retried green, no action)

  • 7 flaky in tests 1 (video screencast on chromium, page-emulate-media/page-goto on firefox, ui-mode-test-output on windows) — all unrelated to tsconfig resolution.

Triaged by the Playwright bot - agent run

@dgozman
dgozman merged commit 28ae3de into microsoft:main Jul 27, 2026
49 of 50 checks passed
dgozman added a commit that referenced this pull request Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants