Skip to content

test: remove "page/page-evaluate.spec.ts:894 › promise collected" - #42019

Merged
dgozman merged 1 commit into
microsoft:mainfrom
dgozman:test-remove-promise-collected
Jul 28, 2026
Merged

test: remove "page/page-evaluate.spec.ts:894 › promise collected"#42019
dgozman merged 1 commit into
microsoft:mainfrom
dgozman:test-remove-promise-collected

Conversation

@dgozman

@dgozman dgozman commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

The behavior has been changed upstream: https://chromium-review.googlesource.com/c/v8/v8/+/8123081.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [firefox] › mcp/cli-core.spec.ts:168 › dialog-accept @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-core.spec.ts:179 › dialog-dismiss @mcp-windows-latest-firefox

7806 passed, 1266 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium-library] › library/video.spec.ts:495 › screencast › should capture static page in persistent context @smoke `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:294 › screencast › should capture navigation `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-page] › page/workers.spec.ts:191 › should attribute network activity for worker inside iframe to the iframe `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:388 › should reveal errors in the sourcetab `@windows-latest-node22`

50732 passed, 1188 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a look at the CI failures here.

🟢 The two failures are a pre-existing flake — this PR is clear

mcp/cli-core.spec.ts:168 (dialog-accept) and :179 (dialog-dismiss) both flake on Firefox on unrelated SHAs. This PR only deletes a page-evaluate test, which doesn't touch the MCP dialog path.

Details

The PR removes a single test (page/page-evaluate.spec.ts:894 › promise collected) and changes nothing else. The only reported failures are in the MCP suite, which the diff doesn't reach.

Pre-existing flake / infra

  • [firefox] › mcp/cli-core.spec.ts:168 › dialog-accept — across the test-results DB this fails on Firefox 8 times over 6 different PRs / 8 SHAs (and once each on chrome and msedge), against 1244 Firefox passes. None of those SHAs are this PR.
  • [firefox] › mcp/cli-core.spec.ts:179 › dialog-dismiss — same story: fails 6 times over 5 PRs / 6 SHAs, against 1246 Firefox passes.

Both are unrelated to a test-only deletion in page-evaluate.spec.ts. Nothing here points at this PR.

Triaged by the Playwright bot - agent run

@dgozman
dgozman merged commit f755ee9 into microsoft:main Jul 28, 2026
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants