Skip to content

fix(mcp): only enable /killkillkill under test #42133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Simon Knott (Skn0tt) merged 1 commit into from
Aug 7, 2026
+3 −9
Merged

fix(mcp): only enable /killkillkill under test #42133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions packages/playwright-core/src/tools/utils/mcp/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import crypto from 'crypto';
import debug from 'debug';
import { SSEServerTransport } from '@modelcontextprotocol/sdk/server/sse.js';
import { StreamableHTTPServerTransport } from '@modelcontextprotocol/sdk/server/streamableHttp.js';
import { isUnderTest } from '@utils/debug';
import { urlHostFromAddress } from '@utils/httpServer';
import { createHttpServer, startHttpServer } from '@utils/network';
import { ManualPromise } from '@isomorphic/manualPromise';
Expand Down Expand Up @@ -82,14 +83,7 @@ async function installHttpTransport(httpServer: http.Server, serverBackendFactor
}

const url = new URL(`http://localhost${req.url}`);
if (url.pathname === '/killkillkill') {
// Require POST plus a custom header to prevent cross-origin CSRF
// (a browser-coerced <img> GET or simple <form> POST can't add custom headers,
// and any cross-origin request with custom headers is blocked by CORS preflight).
if (req.method !== 'POST' || req.headers['x-pw-mcp-kill'] !== '1') {
res.statusCode = 405;
return res.end();
}
if (url.pathname === '/killkillkill' && isUnderTest()) {
res.statusCode = 200;
res.end('Killing process');
// Simulate Ctrl+C in a way that works on Windows too.
Expand Down
2 changes: 1 addition & 1 deletion tests/mcp/http.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ test('http transport browser sigint', async ({ serverEndpoint, server }) => {
arguments: { url: server.HELLO_WORLD },
});

await fetch(new URL('/killkillkill', url).href, { method: 'POST', headers: { 'x-pw-mcp-kill': '1' } }).catch(() => {});
await fetch(new URL('/killkillkill', url).href).catch(() => {});

await expect.poll(() => formatLog(stderr())).toEqual({
'create browser (isolated)': 1,
Expand Down
Loading