test: update webkit expectations for NWLoader on macOS - #42202
test: update webkit expectations for NWLoader on macOS#42202Yury Semikhatsky (yury-s) merged 1 commit into
Conversation
Test results for "tests 1"2 failed 5 flaky51041 passed, 1190 skipped Merge workflow run. |
Test results for "MCP"2 failed 8087 passed, 1284 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟢 Both failures are infra — this PR is clearThe two DetailsPre-existing flake / infra
The 5 flaky entries all passed on retry and are unrelated to the diff, so there's nothing to triage there. Triaged by the Playwright bot - agent run |
|
Hi, I'm the Playwright bot and I took a look at the failing CI. 🟢 The failures are pre-existing flakes — this PR is clearAll four failures are in areas the diff doesn't touch (chromium package installs, MCP drag/http), and each has a flake history on SHAs this PR can't be responsible for. This PR is a test-only change to two WebKit-on-macOS expectations ( DetailsOverall: the PR only relaxes/skips two WebKit-macOS network expectations. None of the four failing tests live in those files or exercise the WebKit network loader, and all four flip verdict across unrelated runs. Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
|
|
||
| it('should include websocket handshake headers and status', async ({ contextFactory, server }, testInfo) => { | ||
| it('should include websocket handshake headers and status', async ({ contextFactory, server, browserName, isMac, macVersion }, testInfo) => { | ||
| it.fixme(browserName === 'webkit' && isMac && macVersion >= 26, 'NWLoader does not reflect the wire handshake headers (Sec-WebSocket-Key, Connection, Upgrade) in NSURLSessionWebSocketTask.currentRequest'); |
There was a problem hiding this comment.
is this fixable? or will it be the reality going forward?
There was a problem hiding this comment.
I don't know, at the first glance it seem to be a problem with NWLoader and should be fixed there, but maybe there is a workaround. I filed #42205 and assigned to you, as this is a recent addition.
1d8f8af
into
microsoft:main
WebKit on macOS is switching from the legacy CFNetwork loader to NWLoader (microsoft/playwright-browsers#2470). Two test expectations change:
page-network-sizes.spec.ts"should have the correct responseBodySize for chunked request": NWLoader reports the correct 5175 (the legacy loader undercounted the chunked encoding bytes as 5173). Transitionally accepts both values until the NWLoader-based build ships, then can be tightened to 5175.har-websocket.spec.ts"should include websocket handshake headers and status": marked fixme for webkit on macOS 26+ — NWLoader there does not reflect the wire handshake headers (Sec-WebSocket-Key,Connection,Upgrade) inNSURLSessionWebSocketTask.currentRequest, so they are missing from the reported handshake request. macOS 15 is unaffected.Refernce https://github.com/microsoft/playwright-browsers/issues/2464