Add parameter --target-env to installCatalog action#407
Merged
Conversation
Contributor
Author
|
We're using public nuget feed now, so set to draft since we need to wait until latest release of pac is on the public feed. |
Contributor
|
I think we should not remove Yes, we need to add new parameter |
Contributor
Author
|
@swapnilbhalgat I incorporated the PR feedback. Thanks! |
devkeydet
changed the title
petrochuk
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pac 1.32.2 now has --target-env to deploy from catalog to target. This addresses a bug in pac. --target-url is deprecated. Quick fix is to do what's in this PR. But, should we create a new parameter in InstallCatalogParameters?