Skip to content

Update CLI Wrapper for Checker to ignore folder paths #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TYLEROL merged 3 commits into from
Feb 10, 2025
+23 −13
Merged

Update CLI Wrapper for Checker to ignore folder paths #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af7a735
Update upload wrapper code to ignore folder paths
TYLEROL Feb 7, 2025
8bf75be
update latest
TYLEROL Feb 7, 2025
1df5607
Remove extra newline in checkSolution.ts
TYLEROL Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,6 @@
},
"dependencies": {
"fs-extra": "^11.1.1",
"glob": "^10.4.1"
"glob": "^10.4.5"
}
}
5 changes: 3 additions & 2 deletions src/actions/checkSolution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import createPacRunner from "../pac/createPacRunner";
import { authenticateAdmin, authenticateEnvironment, clearAuthentication } from "../pac/auth/authenticate";
import { RunnerParameters } from "../Parameters";
import { AuthCredentials } from "../pac/auth/authParameters";
import * as fs from "fs";
import { promises, rmdirSync, rmSync, writeFile } from "fs-extra";

export interface CheckSolutionParameters extends CommonActionParameters {
Expand Down Expand Up @@ -107,8 +108,8 @@ export async function checkSolution(parameters: CheckSolutionParameters, runnerP
const pacResult = await pac(...pacArgs);
logger.log("CheckSolution Action Result: " + pacResult);

const files = glob.sync('**/*', { cwd: outputDirectory, absolute: true });
const artifactStoreName = validator.getInput(parameters.artifactStoreName) || 'CheckSolutionLogs';
const files: string[] = glob.sync('**/*', { cwd: outputDirectory, absolute: true }).filter((file: string) => !fs.lstatSync(file).isDirectory());
const artifactStoreName = validator.getInput(parameters.artifactStoreName) || 'CodeAnalysisLogs';
Comment thread
TYLEROL marked this conversation as resolved.
await artifactStore.upload(artifactStoreName, files);

const status = isolateStatus(pacResult);
Expand Down