Fix build: override ts-sinon @types/node to use root version#491
Merged
Conversation
ts-sinon@2.0.2 depends on @types/node@^14.6.1 which resolves to 14.18.63 in the lock file. The DPX-Tools-Upstream ADO feed cannot proxy this version from npmjs, causing npm ci to fail with 404. Add an npm override to force ts-sinon to use the same @types/node as the root project, eliminating the problematic transitive dep. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MrRishabhJain
force-pushed
the
users/rishjain/fix-types-node-override
branch
from
9cde814 to
8ae37bb
Compare
jbujula
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OneBranch official build has been failing since Jan 2026 because npm ci cannot resolve @types/node@14.18.63 from the DPX-Tools-Upstream ADO feed.
Root cause: ts-sinon@2.0.2 depends on @types/node@^14.6.1 → 14.18.63, which the ADO feed can't proxy.
Fix: Add npm overrides to force ts-sinon to use the root @types/node version. Lock file regenerated against the ADO feed.