bug in update script?

[takacsg84]

qlib/scripts/dump_bin.py

Line 462 in 3480fd9

_df[_df[self.date_field_name] > self._update_instruments[_code][self.INSTRUMENTS_START_FIELD]][

Shouldn't this be

_df[_df[self.date_field_name] > self._update_instruments[_code][self.INSTRUMENTS_END_FIELD]][

instead?

[you-n-g]

@takacsg84
Sorry for the uninformative response, we'll look into the code and response later.

[takacsg84]

In response to @Wangwuyi123 : i thought that the point of that method is to add new information that is not already there, that's why i thought that we should care about data that is after the end date and the start date.

[zhupr]

@takacsg84 Thank you for your feedback
Fixed: #783

[github-actions]

This issue is stale because it has been open for three months with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days