Skip to content

Fix some typo in qlib/tests/data.py#179

Merged
you-n-g merged 1 commit intomicrosoft:mainfrom
fzc621:main
Jan 6, 2021
Merged

Fix some typo in qlib/tests/data.py#179
you-n-g merged 1 commit intomicrosoft:mainfrom
fzc621:main

Conversation

@fzc621
Copy link
Contributor

@fzc621 fzc621 commented Jan 6, 2021

Description

chuck_size -> chunk_size
unlike -> unlink

Motivation and Context

The second typo will result in some bugs when deleting the downloaded zip file.

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

Fix some typo
@you-n-g
Copy link
Collaborator

you-n-g commented Jan 6, 2021

@fzc621 That's great !
Thanks so much!

@you-n-g you-n-g merged commit 4dbc8e5 into microsoft:main Jan 6, 2021
you-n-g pushed a commit to you-n-g/qlib that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants