Skip to content

Modify the Feature to be case sensitive #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
you-n-g merged 1 commit into from
Sep 10, 2021
Merged

Modify the Feature to be case sensitive #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions qlib/data/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,9 @@ class Feature(Expression):

def __init__(self, name=None):
if name:
self._name = name.lower()
self._name = name
else:
self._name = type(self).__name__.lower()
self._name = type(self).__name__

def __str__(self):
return "$" + self._name
Expand Down
2 changes: 1 addition & 1 deletion qlib/data/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,7 @@ def __init__(self, **kwargs):

def feature(self, instrument, field, start_index, end_index, freq):
# validate
field = str(field).lower()[1:]
field = str(field)[1:]
instrument = code_to_fname(instrument)
return self.backend_obj(instrument=instrument, field=field, freq=freq)[start_index : end_index + 1]

Expand Down