Skip to content

Use encoding="utf-8" in open.#773

Merged
you-n-g merged 1 commit intomicrosoft:mainfrom
ChiahungTai:issue772-UnicodeDecodeError
Dec 25, 2021
Merged

Use encoding="utf-8" in open.#773
you-n-g merged 1 commit intomicrosoft:mainfrom
ChiahungTai:issue772-UnicodeDecodeError

Conversation

@ChiahungTai
Copy link
Collaborator

Description

Use parameter encoding="utf-8"in open function.

Motivation and Context

#772
Pass the install script in Windows Big 5 OS.

How Has This Been Tested?

  • Pass the test by running: python setup.py install under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@you-n-g
Copy link
Collaborator

you-n-g commented Dec 25, 2021

It looks great! Thanks so much!

@you-n-g you-n-g merged commit e843e02 into microsoft:main Dec 25, 2021
@ChiahungTai ChiahungTai deleted the issue772-UnicodeDecodeError branch December 28, 2021 12:39
@you-n-g you-n-g added the bug Something isn't working label Jan 12, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants