Skip to content

Fix some warnings in log.py.#805

Merged
you-n-g merged 4 commits intomicrosoft:mainfrom
ChiahungTai:log_warning
Jan 6, 2022
Merged

Fix some warnings in log.py.#805
you-n-g merged 4 commits intomicrosoft:mainfrom
ChiahungTai:log_warning

Conversation

@ChiahungTai
Copy link
Collaborator

Description

Fix some warnings in log.py.

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:

Screen Shot 2022-01-05 at 3 53 45 AM

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@ChiahungTai
Copy link
Collaborator Author

Screen Shot 2022-01-05 at 9 21 14 AM

Screen Shot 2022-01-05 at 9 21 30 AM

This is weird! I pass my black in my pycharm.
@you-n-g
Is there any settings I missed for black?

@you-n-g
Copy link
Collaborator

you-n-g commented Jan 5, 2022

Are you using the latest version of black? @ChiahungTai
image

@ChiahungTai
Copy link
Collaborator Author

Are you using the latest version of black? @ChiahungTai image

Thanks for the diagram. Looks like I miss the argument -l 120.

@ChiahungTai ChiahungTai closed this Jan 5, 2022
@ChiahungTai ChiahungTai deleted the log_warning branch January 5, 2022 14:23
@ChiahungTai ChiahungTai restored the log_warning branch January 5, 2022 14:23
@ChiahungTai ChiahungTai reopened this Jan 5, 2022
@you-n-g
Copy link
Collaborator

you-n-g commented Jan 6, 2022

@ChiahungTai It looks great!
Thanks so much

@you-n-g you-n-g merged commit 6c1332f into microsoft:main Jan 6, 2022
@ChiahungTai ChiahungTai deleted the log_warning branch January 6, 2022 09:08
@you-n-g you-n-g added the bug Something isn't working label Jan 12, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
* Fix some warnings in log.py.

* Fix typo and using black format.

* Fix black.

* Rename dict_ to attrs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants