[949] - Remove argument internal in BaseRun::download_data.#953
Merged
you-n-g merged 3 commits intomicrosoft:mainfrom Mar 8, 2022
ChiahungTai:949
Merged
[949] - Remove argument internal in BaseRun::download_data.#953you-n-g merged 3 commits intomicrosoft:mainfrom ChiahungTai:949
you-n-g merged 3 commits intomicrosoft:mainfrom
ChiahungTai:949
Conversation
Collaborator
|
It looks great! Thanks so much! |
qianyun210603
pushed a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
…t#953) * [949] - Remove argument internal in BaseRun::download_data. * Fix black. * Fix bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove argument internal in BaseRun::download_data.
Motivation and Context
See #949.
How Has This Been Tested?
<! --- Put an
xin all the boxes that apply: --->pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes