Skip to content

bump Node references from 12/14 to 14/16 (#32980) #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amgleitman merged 1 commit into from
Apr 13, 2022
Merged

bump Node references from 12/14 to 14/16 (#32980) #1125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ jobs:
- run:
name: Configure Environment Variables
command: |
echo 'export PATH=/usr/local/opt/node@12/bin:$PATH' >> $BASH_ENV
echo 'export PATH=/usr/local/opt/node@16/bin:$PATH' >> $BASH_ENV
source $BASH_ENV

- with_brew_cache_span:
Expand All @@ -407,6 +407,12 @@ jobs:
- brew_install:
package: applesimutils

- run:
name: Configure Node
# Sourcing find-node.sh will ensure nvm is set up.
# It also helps future invocation of find-node.sh prevent permission issue with nvm.sh.
command: source scripts/find-node.sh && nvm install 16 && nvm alias default 16

- run:
name: Configure Watchman
command: touch .watchmanconfig
Expand Down Expand Up @@ -622,8 +628,8 @@ jobs:
name: Install Node
# Note: Version set separately for non-Windows builds, see above.
command: |
nvm install 14.17.0
nvm use 14.17.0
nvm install 16
nvm use 16

# Setup Dependencies
- run:
Expand Down
2 changes: 1 addition & 1 deletion scripts/validate-ios-test-env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ fi
# Check that the correct version of node is installed
NODE_VERSION="$(command node --version | sed 's/[-/a-zA-Z]//g' |sed 's/.\{2\}$//')"

if (( $(echo "${NODE_VERSION} < 12.0" | bc -l) )); then
if (( $(echo "${NODE_VERSION} < 14.0" | bc -l) )); then
echo "Node ${NODE_VERSION} detected. This version of Node is not supported."
echo "See https://reactnative.dev/docs/getting-started.html for instructions."
exit 1
Expand Down