ci: check yarnrc if it exists #2608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2025
tido64
reviewed
Aug 4, 2025
Comment on lines
+167
to
+170
| // Yarn uses different error format | ||
| if (errorOutput.includes("Invalid authentication") || errorOutput.includes("Failed with errors")) { | ||
| throw new Error(`Invalid or missing auth token for registry: ${registry}`); | ||
| } |
Member
There was a problem hiding this comment.
I wouldn't have this block at all. The catch all below is fine.
Comment on lines
+163
to
+165
| const stderr = whoami.stderr.toString().trim(); | ||
| const stdout = whoami.stdout.toString().trim(); | ||
| const errorOutput = stderr || stdout || 'No error message available'; |
Member
There was a problem hiding this comment.
Not that it matters much, but this is throws away less work:
Suggested change
| const stderr = whoami.stderr.toString().trim(); | |
| const stdout = whoami.stdout.toString().trim(); | |
| const errorOutput = stderr || stdout || 'No error message available'; | |
| const errorOutput = | |
| whoami.stderr.toString().trim() || | |
| whoami.stdout.toString().trim() || | |
| 'No error message available'; |
Collaborator
Author
There was a problem hiding this comment.
I'll add these suggestions to my other open PR
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Aug 4, 2025
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Aug 4, 2025
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Aug 4, 2025
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Our
prepublish-checkassumed we used a.npmrcfile to publish. However, we're now using Yarn V4 which uses its'.yarnrc.ymlto set your registry and auth token. Update the check to handle both.