Skip to content

chore: make example app more informational#1050

Merged
tido64 merged 3 commits intotrunkfrom
tido/improve-example-app
Aug 18, 2022
Merged

chore: make example app more informational#1050
tido64 merged 3 commits intotrunkfrom
tido/improve-example-app

Conversation

@tido64
Copy link
Copy Markdown
Member

@tido64 tido64 commented Aug 16, 2022

Description

Display build parameters in the example app for a better overview. This makes it easier to create screenshots for new versions of react-native.

See also #997 for the current issue with screenshots.

The Fabric detector is borrowed from ScrollViewStickyHeader.js

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

Android iOS iOS with Fabric macOS
Screenshot_1660819993 image Simulator Screen Shot - iPhone 13 - 2022-08-16 at 15 29 48 image

@tido64 tido64 requested review from afoxman and kelset August 16, 2022 14:01
Copy link
Copy Markdown
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested locally and it works like a charm 👍
:shipit:

Screenshot 2022-08-18 at 12 29 51

@tido64 tido64 merged commit bc1107d into trunk Aug 18, 2022
@tido64 tido64 deleted the tido/improve-example-app branch August 18, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants