Integration 9/26/22 #10816
Integration 9/26/22 #10816
Conversation
| '<rootDir>/jest/assetFileTransformer.js', | ||
| }, | ||
| transformIgnorePatterns: [], | ||
| transformIgnorePatterns: ['jest-runner'], |
There was a problem hiding this comment.
Was this added by us or by Meta? If us, could we add a note in the PR description on why we needed to add this to get Jest working?
There was a problem hiding this comment.
We added it to get jest working again! I'll add it to the PR description but it seems like its a jest issue where we shouldn't be transpiliing jest-runner in the first place and this is the work around (jestjs/jest#13173)
There was a problem hiding this comment.
This doesn't affect users of RNW. (or RNWin32). The jest transformer errors out when running against jest-runner.
This code was actually already different than core. Core uses a whitelist of packages within node_modules to run the transforms on, whereas we are running it on everything by default. My guess is due to the monorepo setup.
There was a problem hiding this comment.
Cool thanks for the context!
|
|
||
| // Register to screenshot on each test failure | ||
| global.jasmine.getEnv().addReporter({ | ||
| // TODO - use a jest reporter to create screenshots |
There was a problem hiding this comment.
Is this the API that wasn't working for us following the Jest 29 upgrade?
| @@ -33,6 +33,9 @@ describe('visitAllPages', () => { | |||
| } | |||
|
|
|||
| for (const api of apiExamples) { | |||
| if (api === 'Transforms') | |||
| // disable until either transformExample uses units, or that isn't an error | |||
There was a problem hiding this comment.
Just curious on more context for this comment. Is this from Jest upgrade as well?
There was a problem hiding this comment.
This is a testpage that crashes in core as of this PR: facebook/react-native#34660
facebook/react-native#35292 will fix the test page
chiaramooney
left a comment
chiaramooney
left a comment
There was a problem hiding this comment.
👍 Looks good to me! Because there were so many new issues that came up during this integration, let's just make sure we capture what those bugs were and how we solved them in case similar issues emerge down the line!
4 participants
facebook/react-native@b0aba1b...8cdc9e7