Skip to content

[Telemetry] Add RnwNewArch to MSBuildProperties #14208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielayala94 merged 3 commits into from
Dec 17, 2024
Merged

[Telemetry] Add RnwNewArch to MSBuildProperties #14208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee8c46a
Update OutputMSBuildProperties.targets
danielayala94 Dec 14, 2024
ef68970
Change files
danielayala94 Dec 16, 2024
c59504d
Add UseFabric to the MS Build props
danielayala94 Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-87a27036-cad7-4e7e-a5e1-9f1a77329392.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Add RnwNewArch to MSBuildProperties",
"packageName": "react-native-windows",
"email": "14967941+danielayala94@users.noreply.github.com",
"dependentChangeType": "none"
}
4 changes: 3 additions & 1 deletion vnext/PropertySheets/OutputMSBuildProperties.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@
"WindowsTargetPlatformVersion": "$(WindowsTargetPlatformVersion)",
"UseExperimentalNuGet": "$(UseExperimentalNuGet)",
"UseHermes": "$(UseHermes)",
"UseWinUI3": "$(UseWinUI3)"
"UseWinUI3": "$(UseWinUI3)",

@jonthysell jonthysell Dec 16, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I particularly like it, but you could include UseFabric in here just in case to catch edge cases.

@danielayala94 danielayala94 Dec 16, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What edge cases would be covered by including UseFabric that RnwNewArch would not?

"UseFabric": "$(UseFabric)",
"RnwNewArch": "$(RnwNewArch)"
}
</MSBuildPropertiesJSON>
</PropertyGroup>
Expand Down