Update css-layout dependency#547
Conversation
|
What if we created a wrapper view manager that returned the InlineUIElement type and just added logic to it's ReactShadowNode implementation to call |
|
Or, in theory, you could just put the logic to call I still prefer the first suggestion, but I'm not sure exactly the best way to inject such behavior into Text.windows.js. |
efbc242 to
4ca7d21
Compare
The updated version of css-layout includes significant changes which make the layout engine conform closer to the W3C spec. For details, see react/yoga#185 The inline view implementation had to be modified slightly due to a change in the layout engine. In the updated layout engine, nodes with a measure function are treated as leaves. Consequently, nodes with a mesaure function (e.g. Text) do not have their children laid out automatically. To fix this, Text nodes now manually invoke the layout engine on each of their inline views.
4ca7d21 to
c47ef7b
Compare
|
@rozele I implemented the second suggestion. I don't have a preference between the first and second suggestions but for the first one, I'm not sure how you would wrap each inline view with a special view manager. If you were thinking of having the Text component's render function enumerate |
|
Fixed merge conflict and pushed directly to master. |
The updated version of css-layout includes significant
changes which make the layout engine conform closer to
the W3C spec. For details, see react/yoga#185
The inline view implementation had to be modified slightly
due to a change in the layout engine. In the updated layout
engine, nodes with a measure function are treated as leaves.
Consequently, nodes with a mesaure function (e.g. Text) do
not have their children laid out automatically.
To fix this, Text nodes now manually invoke the layout engine
on each of their inline views.