Skip to content

fix(web-storage): migrate away from deprecated ReactModuleInfo constructor#3434

Merged
tido64 merged 2 commits into
mainfrom
tido/android/deprecated-rmi-constr
Dec 2, 2024
Merged

fix(web-storage): migrate away from deprecated ReactModuleInfo constructor#3434
tido64 merged 2 commits into
mainfrom
tido/android/deprecated-rmi-constr

Conversation

@tido64
Copy link
Copy Markdown
Member

@tido64 tido64 commented Nov 29, 2024

Description

Deprecated ReactModuleInfo constructor was recently removed: facebook/react-native@aec7a66

Failed in RNTA: https://github.com/microsoft/react-native-test-app/actions/runs/12078771069/job/33683653941

Test plan

In RNTA:

npm run set-react-version nightly
yarn clean
yarn

# Manually patch `node_modules/@react-native-webapis/web-storage/android/src/main/java/org/reactnativewebapis/webstorage/WebStoragePackage.kt`

cd example
yarn android

@tido64 tido64 requested a review from Saadnajmi November 29, 2024 14:08
@github-actions github-actions Bot added feature: webapis This is related to the experimental effort around WebAPIs for RN feature: sdk This is related to 1RN SDK labels Nov 29, 2024
@tido64 tido64 force-pushed the tido/android/deprecated-rmi-constr branch from 368adcd to d84c93b Compare November 29, 2024 14:16
@tido64 tido64 merged commit c88c843 into main Dec 2, 2024
@tido64 tido64 deleted the tido/android/deprecated-rmi-constr branch December 2, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: sdk This is related to 1RN SDK feature: webapis This is related to the experimental effort around WebAPIs for RN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants