[rush-pnpm] Fix rush-pnpm patch-commit command #4874
Merged
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-Qun
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton and
octogonz
as code owners
Contributor
Author
|
@iclanton Pete is on vacation. We need your help with the review and merge |
L-Qun
changed the title
Contributor
Author
D4N14L
approved these changes
Aug 9, 2024
iclanton
approved these changes
Aug 10, 2024
common/changes/@microsoft/rush/fix-pnpm-patch_2024-08-09-10-38.json
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
August 10, 2024 01:46
Head branch was pushed to by a user without write access
….json Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
Contributor
Author
|
@iclanton Could you help to publish a new rush version |
Member
|
@L-Qun Published in Rush v5.131.3 |
Contributor
Author
Member
|
@L-Qun - Looks like this PR introduced a breaking change. In the non-subspaces scenario, the patches folder is now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
After upgrading the rush version(5.131.0) in tiktok monorepo, we encountered an error when running
rush-pnpm --subspace subspaceName patch-commit xxxxAfter taking a close look at the rush source code, I found that the path to the folder related to the pnpm patches was incorrect. Therefore, I fixed this issue in that MR
How it was tested
To test the implementation, the following commands were executed:
rush install -t .rush-pnpm --subspace subspaceName patch xxxrush-pnpm --subspace subspaceName patch-commit xxxNo errors were encountered.
Impacted documentation
None