Fix multi-byte UTF-8 decoding in Executable stream handling #5510
+53
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executable.waitForExitAsyncandgetProcessInfoByIdAsyncwere incorrectly decoding multi-byte UTF-8 characters when character boundaries split across stream chunks, producing replacement characters (�) instead of the original text.Changes
Executable.waitForExitAsync: Set encoding on stdout/stderr streams before attaching handlers viastream.setEncoding(). This delegates to Node.js'sStringDecoderwhich maintains state across chunks to handle multi-byte boundaries correctly.Executable.getProcessInfoByIdAsync: Set UTF-8 encoding on stdout before parsing process list output to handle process names with multi-byte characters.Test coverage: Added test that writes multi-byte characters (Chinese text + emoji) byte-by-byte to verify decoding across chunk boundaries.
Example
Before fix:
After fix:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.