[operation-graph] Add Rush-compatible operation statuses#5889
Open
bmiddha wants to merge 1 commit into
Open
Conversation
Add Rush's queued, warning, skipped, and cache statuses to the standalone enum and cover them in exhaustive rerun handling. Existing execution paths continue to emit the same statuses. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bmiddha
requested review from
apostolisms,
dmichon-msft,
iclanton,
jxanthony and
octogonz
as code owners
July 20, 2026 23:29
| */ | ||
| SuccessWithWarning = 'SUCCESS WITH WARNINGS', | ||
| /** | ||
| * The Operation was skipped via legacy incremental build logic. |
Contributor
There was a problem hiding this comment.
Not really legacy anymore, since we use it in some of the frontier strategies.
Comment on lines
+52
to
+56
| Skipped = 'SKIPPED', | ||
| /** | ||
| * The Operation had its outputs restored from the build cache. | ||
| */ | ||
| FromCache = 'FROM CACHE' |
Contributor
There was a problem hiding this comment.
I think in the long term these should be flags, not statuses, since the overall status should still typically be "Success" or similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare
@rushstack/operation-graphfor eventual convergence with rush-lib's stateful operation graph by adding the four operation statuses currently defined only by Rush.This is intentionally a small, non-blocking first increment. It does not change rush-lib or replace its
OperationGraph.Details
Queued,SuccessWithWarning,Skipped, andFromCachetoOperationStatus, using the exact string values already used by rush-lib.requestRunstatus handling so the new values remain type-safe.@rushstack/operation-graphpath starts emitting any new status.@betaAPI change as a minor change and update the API report.The two graph implementations remain structurally different: Rush requires persistent iteration state, selective invalidation, weighted concurrency, and a larger hook/runner contract. Those pieces should converge through later additive APIs and compatibility adapters rather than a big-bang replacement.
How it was tested
node common/scripts/install-run-rush.js test --to @rushstack/operation-graphcd libraries/operation-graph && node_modules/.bin/heft test --clean(27 passed, 0 failed)cd apps/heft && node_modules/.bin/heft build --cleannode common/scripts/install-run-rush.js test --to @microsoft/rush-lib --to @rushstack/operation-graphnode common/scripts/install-run-rush.js change --verifyNo snapshots changed.