.Net: Refactor vector store integration tests - #10556
Merged
Shay Rojansky (roji) merged 1 commit intoFeb 18, 2025
Merged
Conversation
Shay Rojansky (roji)
requested review from
Adam Sitnik (adamsitnik),
Dmytro Struk (dmytrostruk) and
westey (westey-m)
February 15, 2025 23:46
Mark Wallace (markwallace-microsoft)
added
the
.NET
github-actions
Bot
changed the title
Shay Rojansky (roji)
had a problem deploying
to
integration
February 15, 2025 23:46 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Shay Rojansky (roji)
force-pushed
the
IntegrationTestCleanup
branch
from
February 16, 2025 00:00
9dffe2b to
9e351a1
Compare
Shay Rojansky (roji)
had a problem deploying
to
integration
February 16, 2025 00:01 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shay Rojansky (roji)
force-pushed
the
IntegrationTestCleanup
branch
from
February 16, 2025 00:06
9e351a1 to
186f967
Compare
Shay Rojansky (roji)
had a problem deploying
to
integration
February 16, 2025 00:07 — with
GitHub Actions
Failure
GitHub Actions
Failure
Shay Rojansky (roji)
force-pushed
the
IntegrationTestCleanup
branch
from
February 16, 2025 00:18
186f967 to
6de27b8
Compare
Shay Rojansky (roji)
temporarily deployed
to
integration
February 16, 2025 00:18 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Shay Rojansky (roji)
marked this pull request as ready for review
February 16, 2025 00:51
westey (westey-m)
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test-only follow-up PR to #10273, doing various refactoring to the new integration test infra to make it more usable across multiple test suites. It really is almost only shifting around of code for better factoring. Next PRs will be based on top of this to leverage the infra.