.Net: [MEVD] Go over all key types, add support for Guid - #13315
Merged
Conversation
Shay Rojansky (roji)
requested review from
Mark Wallace (markwallace-microsoft) and
westey (westey-m)
October 30, 2025 11:26
Shay Rojansky (roji)
had a problem deploying
to
integration
October 30, 2025 11:26 — with
GitHub Actions
Failure
Shay Rojansky (roji)
force-pushed
the
KeyTypes
branch
from
October 30, 2025 11:54
65efb30 to
c2d8433
Compare
Shay Rojansky (roji)
temporarily deployed
to
integration
October 30, 2025 11:54 — with
GitHub Actions
Inactive
Shay Rojansky (roji)
enabled auto-merge
October 30, 2025 14:07
Mark Wallace (markwallace-microsoft)
approved these changes
Oct 30, 2025
Adam Sitnik (adamsitnik)
approved these changes
Oct 30, 2025
Adam Sitnik (adamsitnik)
left a comment
Member
There was a problem hiding this comment.
LGTM, but please take a look at my comments as some changes seem to be from a different PR. Thank you Shay Rojansky (@roji) for implementing this feature for the Data Ingestion project!
Shay Rojansky (roji)
force-pushed
the
KeyTypes
branch
from
October 31, 2025 08:53
c2d8433 to
e11155c
Compare
Shay Rojansky (roji)
temporarily deployed
to
integration
October 31, 2025 08:54 — with
GitHub Actions
Inactive
westey (westey-m)
approved these changes
Oct 31, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 31, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
byte[]as key types (as above) and added Guid.Closes #11784
Closes #12182