Minor non-functional updates to sample 4 - #138
Merged
Adrian Bonar (adrianwyatt) merged 4 commits intoMar 23, 2023
Merged
Conversation
Tao Chen (TaoChenOSU)
added
the
PR: ready for review
Tao Chen (TaoChenOSU)
requested review from
Craig Presti (craigomatic),
EvanChaki_MSFT (evchaki) and
Teresa Hoang (teresaqhoang)
March 22, 2023 04:46
Devis Lucato (dluc)
requested changes
Mar 22, 2023
Teresa Hoang (teresaqhoang)
added
PR: feedback to address
Tao Chen (TaoChenOSU)
added
PR: ready for review
Craig Presti (craigomatic)
previously approved these changes
Mar 23, 2023
Craig Presti (craigomatic)
left a comment
Craig Presti (craigomatic)
left a comment
Contributor
There was a problem hiding this comment.
Looks good, LGTM
Adrian Bonar (adrianwyatt)
previously approved these changes
Mar 23, 2023
Devis Lucato (dluc)
dismissed stale reviews from Adrian Bonar (adrianwyatt) and Craig Presti (craigomatic)
via
March 23, 2023 20:12
ee3e604
Devis Lucato (dluc)
approved these changes
Mar 23, 2023
Tao Chen (TaoChenOSU)
deleted the
users/taochen/minor_updates_to_sample4
branch
April 14, 2023 21:45
Desmond Howard (dehoward)
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
It is not obvious to users that Sample 4 currently only processes markdown files. 1. Add a paragraph in the sample 4 readme that points out the app only processes markdown files. 2. Add a tooltip in the repo selection page that informs users only the files of the specified type will be processed.
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context Just making this grammatically correct in English. (It was driving me nuts) ### Description Rename "MemoriesStore" to "MemoryStore" ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
It is not obvious to users that Sample 4 currently only processes markdown files.
Description
Contribution Checklist
dotnet format