Name refactoring + move OpenAI code to Connectors namespace - #204
Merged
Conversation
Devis Lucato (dluc)
changed the title
Devis Lucato (dluc)
added
the
PR: ready for review
Devis Lucato (dluc)
force-pushed
the
dluc100-ains
branch
7 times, most recently
from
March 29, 2023 06:52
34d4900 to
c3be718
Compare
Devis Lucato (dluc)
force-pushed
the
dluc100-ains
branch
from
March 29, 2023 06:55
c3be718 to
1dbc718
Compare
Devis Lucato (dluc)
force-pushed
the
dluc100-ains
branch
5 times, most recently
from
March 29, 2023 22:25
2786b9d to
3032035
Compare
Devis Lucato (dluc)
requested review from
Adrian Bonar (adrianwyatt) and
Lee Miller (lemillermicrosoft)
March 29, 2023 23:31
Devis Lucato (dluc)
added
PR: in progress
Devis Lucato (dluc)
force-pushed
the
dluc100-ains
branch
2 times, most recently
from
March 30, 2023 17:19
b1439f6 to
25b917d
Compare
Devis Lucato (dluc)
changed the title
Devis Lucato (dluc)
removed
the
PR: in progress
Devis Lucato (dluc)
added
the
PR: ready for review
Devis Lucato (dluc)
force-pushed
the
dluc100-ains
branch
2 times, most recently
from
March 30, 2023 17:31
1ac3458 to
43fde55
Compare
Abby Harrison (awharrison-28)
previously approved these changes
Mar 30, 2023
Lee Miller (lemillermicrosoft)
previously approved these changes
Mar 30, 2023
Add OpenAI connector Label => Service Id Backend => Service / Connector EmbeddingGenerator => EmbeddingGeneration / TextEmbeddingGeneration Improve extension methods namespaces to reduce "using" statements Prompt config: rename "default_backends" to "default_services"
Devis Lucato (dluc)
dismissed stale reviews from Lee Miller (lemillermicrosoft) and Abby Harrison (awharrison-28)
via
March 30, 2023 18:22
6d4decd
Devis Lucato (dluc)
force-pushed
the
dluc100-ains
branch
from
March 30, 2023 18:22
43fde55 to
6d4decd
Compare
Lee Miller (lemillermicrosoft)
approved these changes
Mar 30, 2023
Desmond Howard (dehoward)
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…t#204) ### Motivation and Context Cleaning up tech debt as per plan, last couple of months * Moved OpenAI code to Connectors namespace * Label => Service Id * Backend => Service / Connector * EmbeddingGenerator => EmbeddingGeneration / TextEmbeddingGeneration
John (johnoliver)
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
…t#204) ### Motivation and Context Cleaning up tech debt as per plan, last couple of months * Moved OpenAI code to Connectors namespace * Label => Service Id * Backend => Service / Connector * EmbeddingGenerator => EmbeddingGeneration / TextEmbeddingGeneration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Cleaning up tech debt as per plan, last couple of months