Ref app sq lite mem store - #245
Closed
Aman Sachan (amsacha) wants to merge 12 commits into
Closed
Conversation
Aman Sachan (amsacha)
force-pushed
the
RefApp_SqLiteMemStore
branch
2 times, most recently
from
March 30, 2023 23:59
8165046 to
eafb38d
Compare
Devis Lucato (dluc)
requested changes
Mar 31, 2023
Aman Sachan (amsacha)
force-pushed
the
RefApp_SqLiteMemStore
branch
4 times, most recently
from
March 31, 2023 18:40
26d9fe0 to
5799748
Compare
Adrian Bonar (adrianwyatt)
requested changes
Mar 31, 2023
Adrian Bonar (adrianwyatt)
added
PR: feedback to address
Adrian Bonar (adrianwyatt)
removed the request for review
from Devis Lucato (dluc)
March 31, 2023 21:35
Devis Lucato (dluc)
left a comment
Devis Lucato (dluc)
left a comment
Contributor
There was a problem hiding this comment.
Please add docblocks
Aman Sachan (amsacha)
force-pushed
the
RefApp_SqLiteMemStore
branch
2 times, most recently
from
March 31, 2023 23:23
b1dd775 to
bade4b4
Compare
Devis Lucato (dluc)
requested changes
Mar 31, 2023
Devis Lucato (dluc)
left a comment
Devis Lucato (dluc)
left a comment
Contributor
There was a problem hiding this comment.
I think there's some confusion on insert, updates and how conflicts are handled
Aman Sachan (amsacha)
requested review from
Adrian Bonar (adrianwyatt) and
Devis Lucato (dluc)
April 1, 2023 00:27
Aman Sachan (amsacha)
force-pushed
the
RefApp_SqLiteMemStore
branch
5 times, most recently
from
April 3, 2023 20:48
d514dba to
8f73b1e
Compare
Aman Sachan (amsacha)
force-pushed
the
RefApp_SqLiteMemStore
branch
from
April 3, 2023 21:57
8f73b1e to
8a935ea
Compare
kernelhttpserver compiles with sqliteMemoryStore;
…g into problem deserializing the interface type of IEmbeddingWithMetadata<TEmbedding>
Updates to deserialization added JsonPropertyName tags to memoryRecord Cleanup: remove sqliteDataStore remove sqlite library solution reset sqliteDataStore to state before my changes; use correct namespace set s couple files back to their state before my changes ran dotnet format
…ll.cs; use UPSERT instead of INSERT for sqlite
…ping it perpetually open
Aman Sachan (amsacha)
force-pushed
the
RefApp_SqLiteMemStore
branch
from
April 4, 2023 20:23
3a08c31 to
69d8c34
Compare
Contributor
|
I would like to hold this until feature-refapp comes into main this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is because we dont have access to those files as they are in another assembly.
Description
Adding a persistent memory store using Sqlite, implemented using the IMemoryStore interface.
Contribution Checklist
dotnet format